OpenFlipper-Free issueshttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues2023-01-25T11:01:41Zhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/183Search-field for plugin list2023-01-25T11:01:41ZJulius Nehring-WirxelSearch-field for plugin listIf there are a lot of plugins it is sometimes quite tedious to find the correct one quickly. It would be nice to have a small search field above the plugin list that can be used to filter the plugins by name and does so while typing.
Li...If there are a lot of plugins it is sometimes quite tedious to find the correct one quickly. It would be nice to have a small search field above the plugin list that can be used to filter the plugins by name and does so while typing.
Like this mockup:
![Mock](/uploads/c9e13f4113af990b3d476e82c734dca5/Mock.png)https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/184Add Toolbox icons2022-12-05T10:15:02ZJan Möbiusmoebius@cs.rwth-aachen.deAdd Toolbox icons![image](/uploads/46c8c3ad9003ead7de1e76e0d8957089/image.png)![image](/uploads/46c8c3ad9003ead7de1e76e0d8957089/image.png)Edwin ÖzdemirEdwin Özdemirhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/165TextNode (Ruler): Garbled text on HiDPI display2021-02-17T11:42:25ZMartin HeistermannTextNode (Ruler): Garbled text on HiDPI displayOn a HiDPI screen on Linux, the ruler plugin TextNode looks like this:
![hidpi-textnode](/uploads/cc70ef034dc419cf6c036cbebc37e93c/hidpi-textnode.png)
It seems only the lower-left quarter of each glyph is used.On a HiDPI screen on Linux, the ruler plugin TextNode looks like this:
![hidpi-textnode](/uploads/cc70ef034dc419cf6c036cbebc37e93c/hidpi-textnode.png)
It seems only the lower-left quarter of each glyph is used.https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/172Selection Line Width2021-02-16T10:40:26ZMax Lyonlyon@cs.rwth-aachen.deSelection Line WidthSetting Line Width in the material properties of a mesh has no effect on the red and purple lines rendered for edges marked as selected or feature.
Similarly, Point Size has no effect on vertices marked as selected or feature.Setting Line Width in the material properties of a mesh has no effect on the red and purple lines rendered for edges marked as selected or feature.
Similarly, Point Size has no effect on vertices marked as selected or feature.Jan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/178Include what you use job for OpenFlipper2021-02-01T12:07:40ZJan Möbiusmoebius@cs.rwth-aachen.deInclude what you use job for OpenFlipperPlease create a new build job which uses include what you use (Linux only):
Maybe we need to include a mapping file to handle Qt 5 correctly
Beispiel:
cmake -DCMAKE_CXX_INCLUDE_WHAT_YOU_USE="iwyu" ../OpenFlipper-FreePlease create a new build job which uses include what you use (Linux only):
Maybe we need to include a mapping file to handle Qt 5 correctly
Beispiel:
cmake -DCMAKE_CXX_INCLUDE_WHAT_YOU_USE="iwyu" ../OpenFlipper-FreeJohannes LenzenJohannes Lenzenhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/181CI error on Windows: "error: cannot spawn git: Read-only file system"2020-12-02T13:17:34ZMartin HeistermannCI error on Windows: "error: cannot spawn git: Read-only file system"https://www.graphics.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/jobs/117773
```
[...]
Cloning into 'E:/gitlab/builds/cu6mRa6g/0/OpenFlipper-Free/OpenFlipper-Free/Plugin-PrimitivesGenerator'...
WARNING: Failed to terminate pr...https://www.graphics.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/jobs/117773
```
[...]
Cloning into 'E:/gitlab/builds/cu6mRa6g/0/OpenFlipper-Free/OpenFlipper-Free/Plugin-PrimitivesGenerator'...
WARNING: Failed to terminate process: exit status 1
WARNING: Failed to force-kill: exit status 1
Cloning into 'E:/gitlab/builds/cu6mRa6g/0/OpenFlipper-Free/OpenFlipper-Free/Plugin-Print'...
Cloning into 'E:/gitlab/builds/cu6mRa6g/0/OpenFlipper-Free/OpenFlipper-Free/Plugin-PropertyVis'...
Cloning into 'E:/gitlab/builds/cu6mRa6g/0/OpenFlipper-Free/OpenFlipper-Free/Plugin-Remesher'...
Cloning into 'E:/gitlab/builds/cu6mRa6g/0/OpenFlipper-Free/OpenFlipper-Free/Plugin-Ruler'...
Cloning into 'E:/gitlab/builds/cu6mRa6g/0/OpenFlipper-Free/OpenFlipper-Free/Plugin-Scripting'...
Cloning into 'E:/gitlab/builds/cu6mRa6g/0/OpenFlipper-Free/OpenFlipper-Free/Plugin-SimpleSmoother'...
Cloning into 'E:/gitlab/builds/cu6mRa6g/0/OpenFlipper-Free/OpenFlipper-Free/Plugin-SkeletalAnimation'...
error: cannot spawn git: Read-only file system
fatal: clone of 'https://www.graphics.rwth-aachen.de:9000/OpenFlipper-Free/Plugin-SkeletalAnimation.git' into submodule path 'E:/gitlab/builds/cu6mRa6g/0/OpenFlipper-Free/OpenFlipper-Free/Plugin-SkeletalAnimation' failed
Failed to clone 'Plugin-SkeletalAnimation'. Retry scheduled
error: cannot spawn git: Read-only file system
```Jan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/179Chek Windows Installer from artifacts2020-11-24T08:47:04ZJan Möbiusmoebius@cs.rwth-aachen.deChek Windows Installer from artifactsJohannes LenzenJohannes Lenzenhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/100move away from deprecated QTScript to QJSEngine based scripting2020-11-24T08:33:04ZJascha Wedowskimove away from deprecated QTScript to QJSEngine based scriptingQTScript is deprecated since QT 5.5 (?), recommended alternative is QJSEngine.
Problems with moving away are:
* QTScript systems are present in interfaces -> interfaces will have to change
* As a result of this, plugins using the script...QTScript is deprecated since QT 5.5 (?), recommended alternative is QJSEngine.
Problems with moving away are:
* QTScript systems are present in interfaces -> interfaces will have to change
* As a result of this, plugins using the scripting system have to be touched
First step: Abstract direct usage of QTScript classes in usage code (i.e. PropertyVisPlugin) to find suitable new abstraction
When this is done, make all usage code use new abstraction, then incrementally port internals to QJSEngine.Jascha WedowskiJascha Wedowskihttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/113Ruler plugin behaves funny2020-11-24T08:32:42ZMartin SchultzRuler plugin behaves funnythe ruler plugin seems to measure funny.
e.g. I create a cube and measure the cube with the ruler plugin.
when the mouse is not over the cube, the ruler line seems to change length arbitrarily depending on the positions of the mouse.
al...the ruler plugin seems to measure funny.
e.g. I create a cube and measure the cube with the ruler plugin.
when the mouse is not over the cube, the ruler line seems to change length arbitrarily depending on the positions of the mouse.
also the line of the ruler plugin moves slow, which makes it feel odd since the line is not attached to the mousehttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/170Assertion fails in GLMatrixT when zooming to triangle2020-11-23T06:02:47ZMax Lyonlyon@cs.rwth-aachen.deAssertion fails in GLMatrixT when zooming to triangleSteps to reproduce:
- Build in debug mode
- Add triangle:
```
int id;
emit addEmptyObject( DATA_TRIANGLE_MESH, id);
auto& mesh_obj = *PluginFunctions::triMeshObject(id);
auto& mesh = *PluginFunctions::triMesh(id);
mesh.add_ver...Steps to reproduce:
- Build in debug mode
- Add triangle:
```
int id;
emit addEmptyObject( DATA_TRIANGLE_MESH, id);
auto& mesh_obj = *PluginFunctions::triMeshObject(id);
auto& mesh = *PluginFunctions::triMesh(id);
mesh.add_vertex(TriMesh::Point(0,0,0));
mesh.add_vertex(TriMesh::Point(1,0,0));
mesh.add_vertex(TriMesh::Point(0,1,0));
mesh.add_face(OpenMesh::VertexHandle(0), OpenMesh::VertexHandle(1), OpenMesh::VertexHandle(2));
```
- Right click mesh in DataControl widget and click "zoom to object"https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/167Edge property visualization with property visualizer plugin2020-11-20T09:13:02ZNicolas Gallego-OrtizEdge property visualization with property visualizer pluginSystem: macOS 10.14.6, c++ compiler clang-1000.11.45.5, cmake 3.14.5,
Debug mode, using Qt Creator 4.9.2
Shader: pipeline render plugin, (although changing it does not change the behavior)
Hi all,
I just observed this unexpected be...System: macOS 10.14.6, c++ compiler clang-1000.11.45.5, cmake 3.14.5,
Debug mode, using Qt Creator 4.9.2
Shader: pipeline render plugin, (although changing it does not change the behavior)
Hi all,
I just observed this unexpected behavior when visualizing edge properties of meshes (OpenMesh) with the property visualization plugin. I the provided file there is a triangle mesh of a plane, and an edge property saved from it.
I get this error message on the console, and the mesh is rendered as a tube on the z-direction as shown in the image. The plane mesh can be seen after clicking on the object for a short time but the edges shown are not those of the original mesh.
I would be happy to help solve this issue, for now just let me know if you can reproduce it in other systems and some hints on where to start the debugging process.
Thanks,
Nicolas
```
GLError /Users/nicolas.gallego-ortiz/projects/OpenFlipper-072019/OpenFlipper/libs_required/ACG/ShaderUtils/GLSLShader.cc:650 - 1282
GLError /Users/nicolas.gallego-ortiz/projects/OpenFlipper-072019/OpenFlipper/libs_required/ACG/ShaderUtils/GLSLShader.cc:704 - 1282 - inColor
```
[mesh2.om](/uploads/7d19640750d0d63bac96123c433397d2/mesh2.om)
[kappa.eprop](/uploads/85cb68a117b9b3876525ecc5ce580307/kappa.eprop)
![screenshot](/uploads/086c07c3b29a4618be864f85cb6e206e/screenshot.png)Nicolas Gallego-OrtizNicolas Gallego-Ortizhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/176Intermittent UIC related compile failures with CMake 3.18 on Windows2020-11-20T09:13:02ZMartin HeistermannIntermittent UIC related compile failures with CMake 3.18 on WindowsWith the following setup, in many compile runs, some `ui_*.h` files are not found, i.e. UIC is not run:
- Windows 10
- MSVC 2019
- Qt 5.15
- CMake 3.18
Sometimes, regenerating the project, switching between release/debug types ...With the following setup, in many compile runs, some `ui_*.h` files are not found, i.e. UIC is not run:
- Windows 10
- MSVC 2019
- Qt 5.15
- CMake 3.18
Sometimes, regenerating the project, switching between release/debug types and full solution rebuilds actually yield a success, but I haven't been able to figure out any pattern.
Not all `ui_*.h` files are missing (the build results in an incomplete OF that works, but is without the DataControl plugin), however I also couldn't make out what makes the failing ones special. The following ones 'tend' to fail:
- `ui_QtMaterialDialogUi.h`
- `ui_lightWidget.h`
With CMake 3.14 (everything else unchanged), the issues do not seem to appear.
This behavior occurs both on my machine and on the machine of one of our students.https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/166CI does not notice test failures on Windows2020-11-19T13:44:30ZMartin HeistermannCI does not notice test failures on Windowscf https://www.graphics.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/jobs/79535
```
The following tests FAILED:
5 - PLUGIN-DATACONTROL-dataType.ofp (Failed)
6 - PLUGIN-DATACONTROL-group.ofp (Failed)
8 - PLUGIN-SMOOTH...cf https://www.graphics.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/jobs/79535
```
The following tests FAILED:
5 - PLUGIN-DATACONTROL-dataType.ofp (Failed)
6 - PLUGIN-DATACONTROL-group.ofp (Failed)
8 - PLUGIN-SMOOTHER-smoother_c0_normal_10.ofp-cube_sharp.off (Failed)
Errors while running CTest
```Johannes LenzenJohannes Lenzenhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/177Plugin Smoother: Test is failing with python support disabled #1083732020-10-30T11:50:11ZJohannes LenzenPlugin Smoother: Test is failing with python support disabled #108373The PLUGIN-SMOOTHER-smoother_c0_normal_10.ofp-cube_sharp.off test fails when disabling python support for OpenFlipper with -DDISABLE_OPENFLIPPER_PYTHON_SYSTEM=TRUE
Running the PLUGIN-SMOOTHER-smoother_c0_normal_10.ofp-cube_sharp.off whi...The PLUGIN-SMOOTHER-smoother_c0_normal_10.ofp-cube_sharp.off test fails when disabling python support for OpenFlipper with -DDISABLE_OPENFLIPPER_PYTHON_SYSTEM=TRUE
Running the PLUGIN-SMOOTHER-smoother_c0_normal_10.ofp-cube_sharp.off while python support is switched off results in the following error: Job [#108373](https://www.graphics.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/jobs/108373) failed for 9ca922b688ae5b02796a0e9c28c6a8ff970fd696:Jan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/173Loading Objects moves progressbar behind filepicker2020-08-13T13:11:32ZZain SelmanLoading Objects moves progressbar behind filepickerAs apparent in the screenshot the filepicker hovers above the progressbar window. Not knowing whether it is loading the file or not, can be confusing if not aware of this and the progressbar is completely covered (as it is default).
![im...As apparent in the screenshot the filepicker hovers above the progressbar window. Not knowing whether it is loading the file or not, can be confusing if not aware of this and the progressbar is completely covered (as it is default).
![image](/uploads/faf24a3d0d42a2e16ac17979aeae9802/image.png)https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/171CMake 3.17 Policy CMP0100 Problem2020-04-30T10:56:09ZMartin HeistermannCMake 3.17 Policy CMP0100 ProblemWhen running the CI pipeline for current master, that successfully passed in the past <https://www.graphics.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/pipelines/13920>, now it fails on mac: <https://www.graphics.rwth-aachen.de...When running the CI pipeline for current master, that successfully passed in the past <https://www.graphics.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/pipelines/13920>, now it fails on mac: <https://www.graphics.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/pipelines/14006>
```
[ 31%] Building CXX object OpenFlipper/libs_required/ACG/CMakeFiles/ACG.dir/QtWidgets/QtClippingDialog.cc.o
In file included from /Users/jenkins/builds/8dfb9a4a/0/OpenFlipper-Free/OpenFlipper-Free/OpenFlipper/libs_required/ACG/QtWidgets/QtClippingDialog.cc:55:
/Users/jenkins/builds/8dfb9a4a/0/OpenFlipper-Free/OpenFlipper-Free/OpenFlipper/libs_required/ACG/QtWidgets/QtClippingDialog.hh:60:10: fatal error: 'ui_QtClippingDialogUi.h' file not found
#include "ui_QtClippingDialogUi.h"
^
1 error generated.
```Jan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/92Write unittest for Merge plugin2020-04-23T09:47:48ZMartin SchultzWrite unittest for Merge pluginit seems like the merge plugin is not copying the properties in the merge process as intended.
Investigate and fix this, s.t. at least standard properties are copied.
In addition to that write a unittest to check if properties are copied...it seems like the merge plugin is not copying the properties in the merge process as intended.
Investigate and fix this, s.t. at least standard properties are copied.
In addition to that write a unittest to check if properties are copied as intended.https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/136Cross-Plugin RTTI / dynamic_cast / OVM properties2020-04-21T13:29:00ZMartin HeistermannCross-Plugin RTTI / dynamic_cast / OVM propertiesOn macOS, dynamic_cast between Plugins is broken, as typeinfo/RTTI is not shared between plugins.
This breaks OVM property lookup, e.g. the PropertyVisualizer cannot access OVM properties created in another plugin, but rather creates its...On macOS, dynamic_cast between Plugins is broken, as typeinfo/RTTI is not shared between plugins.
This breaks OVM property lookup, e.g. the PropertyVisualizer cannot access OVM properties created in another plugin, but rather creates its own uninitialised properties with the same name, because the dynamic_cast on the correct property returns NULL, so it cannot be found. (Side note: maybe an optional request_property bool parameter like `fail_if_missing` would be useful?).
@lyon created a workaround for this by defining `OVM_FORCE_STATIC_CAST`, which will avoid the dynamic_cast, however this is at the cost of type safety and making it impossible to have multiple properties of different types sharing the same name.
I tried to fix this properly by setting a QPluginLoader option (`ExportExternalSymbolsHint`) that exports one plugin's symbols to the other plugins, cf https://www.graphics.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper/tree/fix_plugin_rtti_macos
This nicely fixed the issue on macOS, however I get immediate crashes on startup on Linux, I assume this is due to different things with the same symbol name in multiple Plugins that get mixed up.
Potential solutions:
* ExportExternalSymbolsHint + more appropriate `-fvisibility` settings to avoid Linux issues (leveraging windows dllexport macros?)
* Keeping RTTI info for all types that should be shared between Plugins in main OpenFlipper
* simple hand-rolled RTTI for OVM props to achieve better type safety, e.g. comparing type names from typeid().
* dirty fix: only enable `ExportExternalSymbolsHint` on macOS
Open questions:
* Why does this even work on Linux & Windows? (EDIT: libstdc++ seems to use strcmp based type comparison, cf http://lists.llvm.org/pipermail/llvm-dev/2014-June/073465.html - libc++ does not and relies on the linker)
* Which symbol collisions cause the Linux crash?
* How is this done in OpenMesh?https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/168Current 4.0 release does not work with Qt > 5.9 and starts with black screen2020-03-17T16:43:11ZMartin HeistermannCurrent 4.0 release does not work with Qt > 5.9 and starts with black screenThe current 4.0 release still has a long-fixed bug in the cmake scripts that breaks it for Qt > 5.9 (broken regex that assumes 1 character for the minor release number).
The other big issue is #164 that causes users to be greeted with a...The current 4.0 release still has a long-fixed bug in the cmake scripts that breaks it for Qt > 5.9 (broken regex that assumes 1 character for the minor release number).
The other big issue is #164 that causes users to be greeted with a black screen unless they figure out to change the renderer.
Maybe we could have a new release soon?Jan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/164Core profile: avoid default internal renderer2020-01-13T17:29:51ZMartin HeistermannCore profile: avoid default internal rendererWhen OF is running in Core profile renderer code, the legacy GL "Default internal renderer" is still selected as default, which results in an empty 3D view, which is confusing to new users.
I guess we should disable it in this case and s...When OF is running in Core profile renderer code, the legacy GL "Default internal renderer" is still selected as default, which results in an empty 3D view, which is confusing to new users.
I guess we should disable it in this case and select the shader pipeline renderer as default in that case.Kersten SchusterKersten Schuster