Skip to content

GitLab

Switch branch/tag
  1. 19 Dec, 2018 1 commit
  3. 13 Nov, 2018 1 commit
    • Martin Heistermann's avatar
      Fix crash on window close event. · 05f49233
      Martin Heistermann authored 
      Likely made visible by Qt 5.11, but was was broken before.

Due to a direct qt connection, the CoreWidget is being destroyed while
a) a CoreWidget method is on the stack
b) the close event is not fully handled yet.

Valgrind output for reference:

==6374== Invalid read of size 8
==6374==    at 0x71C64A1: QWindow::destroy() (in /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.11.2)
==6374==    by 0x71C70DE: QWindow::event(QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.11.2)
==6374==    by 0x6C02F37: ??? (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.2)
==6374==    by 0x6BA7490: QApplicationPrivate::notify_helper(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.2)
==6374==    by 0x6BAEACF: QApplication::notify(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.2)
==6374==    by 0x7893038: QCoreApplication::notifyInternal2(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.11.2)
==6374==    by 0x71B7DB9: QGuiApplicationPrivate::processCloseEvent(QWindowSystemInterfacePrivate::CloseEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.11.2)
==6374==    by 0x71BCA54: QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.11.2)
==6374==    by 0x7196D8A: QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) (in /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.11.2)
==6374==    by 0xCA5685A: ??? (in /usr/lib/x86_64-linux-gnu/libQt5XcbQpa.so.5.11.2)
==6374==    by 0x7891D0A: QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.11.2)
==6374==    by 0x7899E81: QCoreApplication::exec() (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.11.2)
==6374==    by 0x33C6F2: main (OpenFlipper.cc:802)
==6374==  Address 0xc5fc6e8 is 8 bytes inside a block of size 88 free'd
==6374==    at 0x4836EEB: operator delete(void*) (vg_replace_malloc.c:576)
==6374==    by 0x6BD4CAA: QWidgetPrivate::deleteTLSysExtra() (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.2)
==6374==    by 0x6BD97D7: QWidget::destroy(bool, bool) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.2)
==6374==    by 0x6BE10E1: QWidget::~QWidget() (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.2)
==6374==    by 0x438381: CoreWidget::~CoreWidget() (CoreWidget.cc:658)
==6374==    by 0x4383A5: CoreWidget::~CoreWidget() (CoreWidget.cc:660)
==6374==    by 0x382D4C: Core::slotExit() (Core.cc:1219)
==6374==    by 0x504948: Core::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (moc_Core.cpp:1559)
==6374==    by 0x78BC28A: QMetaObject::activate(QObject*, int, int, void**) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.11.2)
==6374==    by 0x515DFC: CoreWidget::exit() (moc_CoreWidget.cpp:1602)
==6374==    by 0x439BA9: CoreWidget::closeEvent(QCloseEvent*) (CoreWidget.cc:912)
==6374==    by 0x6BE57C7: QWidget::event(QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.2)
==6374==    by 0x6CEBED3: QMainWindow::event(QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.2)
==6374==    by 0x43A82F: CoreWidget::event(QEvent*) (CoreWidget.cc:1103)
==6374==    by 0x6BA7490: QApplicationPrivate::notify_helper(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.2)
==6374==    by 0x6BAEACF: QApplication::notify(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.2)
==6374==    by 0x7893038: QCoreApplication::notifyInternal2(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.11.2)
==6374==    by 0x6BE0CC0: QWidgetPrivate::close_helper(QWidgetPrivate::CloseMode) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.2)
==6374==    by 0x6BFFD1D: ??? (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.2)
==6374==    by 0x6C02F2C: ??? (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.2)
==6374==    by 0x6BA7490: QApplicationPrivate::notify_helper(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.2)
==6374==    by 0x6BAEACF: QApplication::notify(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.2)
==6374==    by 0x7893038: QCoreApplication::notifyInternal2(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.11.2)
==6374==    by 0x71B7DB9: QGuiApplicationPrivate::processCloseEvent(QWindowSystemInterfacePrivate::CloseEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.11.2)
      05f49233
  5. 02 May, 2018 1 commit
  7. 24 Apr, 2018 1 commit
  9. 21 Mar, 2018 3 commits
  11. 16 Feb, 2018 1 commit
  13. 13 Feb, 2018 1 commit
  15. 09 Feb, 2018 1 commit
  17. 15 Sep, 2017 1 commit
  19. 26 Apr, 2017 1 commit
  21. 24 Oct, 2016 1 commit
  23. 21 Oct, 2016 1 commit
  25. 10 Aug, 2016 1 commit
  27. 02 Jun, 2016 1 commit
  29. 13 May, 2016 1 commit
  31. 12 May, 2016 1 commit
  33. 10 May, 2016 1 commit
    • Martin Schultz's avatar
      Revert "Merge branch 'newGLLoader' into 'master' · aa803cfc
      Martin Schultz authored 
      As the new glLoad is not compatible with Qt 5.6 we will continue using
glew for now.

This reverts commit 22938119ac1bcf60ad49078c7fa436856bc7c902, reversing
changes made to ed8a9a65a94b8d72b80133d37ddbf4a8c029988a.
      aa803cfc
  35. 07 May, 2016 2 commits
  37. 25 Jan, 2016 1 commit
  39. 07 Dec, 2015 1 commit
  41. 30 Nov, 2015 1 commit
  43. 14 Aug, 2015 1 commit
  45. 16 Jul, 2015 1 commit
  47. 01 Oct, 2014 1 commit
  49. 02 Jul, 2014 1 commit
  51. 26 Jun, 2014 1 commit
  53. 12 Feb, 2014 1 commit
  55. 05 Feb, 2014 1 commit
  57. 07 Jan, 2014 1 commit
  59. 20 Dec, 2013 1 commit
  61. 30 Sep, 2013 3 commits
  63. 27 Sep, 2013 1 commit
  65. 17 Sep, 2013 1 commit
  67. 13 Sep, 2013 1 commit
  69. 27 Aug, 2013 1 commit