From 3b8a93dd8ae2de443164119078f37c071d5b3fbf Mon Sep 17 00:00:00 2001
From: Martin Heistermann <git@mheistermann.de>
Date: Mon, 27 May 2019 21:17:01 +0200
Subject: [PATCH] Fix danging reference bug caused by halfedge().from_vertex().

We should not return references to members of possible xvalues.
Handle is lightweight enough that copying is not a problem.
---
 src/OpenVolumeMesh/Core/BaseEntities.hh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/OpenVolumeMesh/Core/BaseEntities.hh b/src/OpenVolumeMesh/Core/BaseEntities.hh
index 787d171..738f6f1 100644
--- a/src/OpenVolumeMesh/Core/BaseEntities.hh
+++ b/src/OpenVolumeMesh/Core/BaseEntities.hh
@@ -61,10 +61,10 @@ public:
     virtual ~OpenVolumeMeshEdge() {
     }
 
-    const VertexHandle& from_vertex() const {
+    const VertexHandle from_vertex() const {
         return fromVertex_;
     }
-    const VertexHandle& to_vertex() const {
+    const VertexHandle to_vertex() const {
         return toVertex_;
     }
 
-- 
GitLab