typed-geometry issueshttps://gitlab.vci.rwth-aachen.de:9000/ptrettner/typed-geometry/-/issues2021-07-01T14:01:23Zhttps://gitlab.vci.rwth-aachen.de:9000/ptrettner/typed-geometry/-/issues/11`tg::comp<D, ...>::zero` is broken (missing in `special_values.hh`)2021-07-01T14:01:23ZZain Selman`tg::comp<D, ...>::zero` is broken (missing in `special_values.hh`)For `tg::comp<>` there is `static const comp zero;` defined (in `comp.hh`), which does not exist in `special_values.hh` unlike the `vec/dir/pos/etc`-types.
Usage like
```cpp
TEST("comp_zero")
{
LOG("hello: {}", tg::comp2::zero);
}
``...For `tg::comp<>` there is `static const comp zero;` defined (in `comp.hh`), which does not exist in `special_values.hh` unlike the `vec/dir/pos/etc`-types.
Usage like
```cpp
TEST("comp_zero")
{
LOG("hello: {}", tg::comp2::zero);
}
```
results in a `error: undefined reference to 'tg::comp<2, float>::zero'` error.Philip TrettnerPhilip Trettnerhttps://gitlab.vci.rwth-aachen.de:9000/ptrettner/typed-geometry/-/issues/10tg::always_false<D> partially breaks under clang 122021-06-14T12:53:36ZZain Selmantg::always_false<D> partially breaks under clang 12When using clang 12.0.0, all occurences of `tg::always_false<D>` where `D` is not a type cause a compilation error. I.e. D being an int for dimension checking.
This can be observed mainly for the `matrix/eigenvalues.hh` header, where it ...When using clang 12.0.0, all occurences of `tg::always_false<D>` where `D` is not a type cause a compilation error. I.e. D being an int for dimension checking.
This can be observed mainly for the `matrix/eigenvalues.hh` header, where it is frequently used to check the dimension of the matrix.
I've checked the following snipped using [godbolt](https://godbolt.org/z/cfTE1nP7K):
```
template <class...>
constexpr bool always_false = false;
template <int D>
void test()
{
if constexpr (D <= 4)
{
return;
}
else
{
static_assert(always_false<D>, "unsupported dimension");
return;
}
}
```
Starting with clang 12.0.0 the snippet is not valid anymore.https://gitlab.vci.rwth-aachen.de:9000/ptrettner/typed-geometry/-/issues/8submatrix2019-05-22T13:05:55ZJulian Schakibsubmatrixunsure whether submatrix is working the way it should. the matrix returned is always of size SCxSR, however those are also used as the "end" row and column. that means you cant access the middle column for example.unsure whether submatrix is working the way it should. the matrix returned is always of size SCxSR, however those are also used as the "end" row and column. that means you cant access the middle column for example.Philip TrettnerPhilip Trettner